XeLabs/100-go-mistakes
2
0
Fork 0
mirror of https://github.com/teivah/100-go-mistakes.git synced 2026-06-20 16:45:56 +08:00
Code Issues Projects Releases Packages Wiki Activity

Mistake #100: outdated since Go 1.25 container-aware GOMAXPROCS

Browse source
This commit is contained in:
Muhammet Arıkan 2025-08-15 00:14:49 +03:00 committed by GitHub
parent d21c8462b1
commit 5af6373825
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
docs/index.md
View file

@ -2426,21 +2426,11 @@ Read the full section [here](98-profiling-execution-tracing.md).
Understanding how to tune the GC can lead to multiple benefits such as handling sudden load increases more efficiently.
### Not understanding the impacts of running Go in Docker and Kubernetes (#100)
???+ info "TL;DR"
To help avoid CPU throttling when deployed in Docker and Kubernetes, keep in mind that Go isn’t CFS-aware.
By default, GOMAXPROCS is set to the number of OS-apparent logical CPU cores.
When running some Go code inside Docker and Kubernetes, we must know that Go isn't CFS-aware ([github.com/golang/go/issues/33803](https://github.com/golang/go/issues/33803)). Therefore, GOMAXPROCS isn't automatically set to the value of `spec.containers.resources.limits.cpu` (see [Kubernetes Resource Management for Pods and Containers](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/)); instead, it's set to the number of logical cores on the host machine. The main implication is that it can lead to an increased tail latency in some specific situations.
One solution is to rely on [uber-go/automaxprocs](https://github.com/uber-go/automaxprocs) that automatically set `GOMAXPROCS` to match the Linux container CPU quota.
### :warning: Not understanding the impacts of running Go in Docker and Kubernetes (#100)
???+ warning
automaxprocs does not work for workloads running in AWS ECS [issue #66](https://github.com/uber-go/automaxprocs/issues/66). Use [rdforte/gomaxecs](https://github.com/rdforte/gomaxecs) instead.
This mistake isn't relevant anymore from Go 1.25 ([details](https://go.dev/doc/go1.25#container-aware-gomaxprocs)).
## Community