From b8feda3caae7e0b0f5ded6ffe3c2e2675abe2796 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20Geisend=C3=B6rfer?= Date: Thu, 10 Feb 2022 02:16:56 +0100 Subject: [PATCH] fix typo --- guide/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guide/README.md b/guide/README.md index 39067e8..dff2ddf 100644 --- a/guide/README.md +++ b/guide/README.md @@ -1,4 +1,4 @@ -⬅ [Index of all go-profiler-notes](../README.md) +li⬅ [Index of all go-profiler-notes](../README.md) # The Busy Developer's Guide to Go Profiling, Tracing and Observability - **[Introduction](#introduction):** [Read This](#read-this) · [Mental Model for Go](#mental-model-for-go) · Profiling vs Tracing @@ -339,7 +339,7 @@ The `free_*` counters themselves are not included in the final memory profile. I There are a few known issues and limitations of the memory profiler that you might want to be aware of: -- 🐞 [GH #49171](https://github.com/golang/go/issues/49171): Delta profiles (taken with e.g. `GET /debug/pprof/allocs?seconds=60`) may report negative allocation counts due to symbolization bug for inlined closures in Go 1.17. It's fixed in Go 1.18. +- 🐞 [GH #49171](https://github.com/golang/go/issues/49171): Delta profiles (taken with e.g. `GET /debug/pprof/allocs?seconds=60`) may report negative allocation counts due to a symbolization bug involving inlined closures in Go 1.17. It's fixed in Go 1.18. - ⚠️ [`runtime.MemProfileRate`](https://pkg.go.dev/runtime#MemProfileRate) must only be modified once, as early as possible in the startup of the program; for example, at the beginning of `main()`. Writing this value is inherently a small data race, and changing it multiple times during program execution will produce incorrect profiles. - ⚠ When debugging potential memory leaks, the memory profiler can show you where those allocations were created, but it can't show you which references are keeping them alive. A few attempts to solve this problem were made over the years, but none of them work with recent versions of Go. If you know about a working tool, please [let me know](https://github.com/DataDog/go-profiler-notes/issues). - ⚠ [CPU Profiler Labels](#cpu-profiler-labels) or similar are not supported by the memory profiler. It's difficult to add this feature to the current implementation as it could create a memory leak in the internal hash map that holds the memory profiling data.