2
0
Fork 0
mirror of https://github.com/ii64/sonic.git synced 2026-06-21 00:46:43 +08:00

feat: add dummy implementation of pretouch() for !amd64 arch (#306)

* feat: 🎸 (sonic.go): Add none implement for !amd64 arch

 Closes: #301

* Add test

* Address comment
This commit is contained in:
Keyi Xie 2022-09-28 13:58:24 +08:00 committed by GitHub
parent 56e81a633e
commit b52e528dc6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 59 additions and 1 deletions

View file

@ -1,3 +1,4 @@
//go:build !amd64
// +build !amd64
/*
@ -22,6 +23,9 @@ import (
`bytes`
`encoding/json`
`io`
`reflect`
`github.com/bytedance/sonic/option`
)
type frozenConfig struct {
@ -115,3 +119,15 @@ func (cfg *frozenConfig) NewDecoder(reader io.Reader) Decoder {
func (cfg *frozenConfig) Valid(data []byte) bool {
return json.Valid(data)
}
// Pretouch compiles vt ahead-of-time to avoid JIT compilation on-the-fly, in
// order to reduce the first-hit latency at **amd64** Arch.
// Opts are the compile options, for example, "option.WithCompileRecursiveDepth" is
// a compile option to set the depth of recursive compile for the nested struct type.
// * This is the none implement for !amd64.
// It will be useful for someone who develop with !amd64 arch,like Mac M1.
func Pretouch(vt reflect.Type, opts ...option.CompileOption) error {
return nil
}

42
compat_test.go Normal file
View file

@ -0,0 +1,42 @@
//go:build !amd64
// +build !amd64
/*
* Copyright 2022 ByteDance Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package sonic
import (
`reflect`
`testing`
`github.com/bytedance/sonic/option`
)
func TestPretouch(t *testing.T) {
var v map[string]interface{}
if err := Pretouch(reflect.TypeOf(v)); err != nil {
t.Errorf("err:%v", err)
}
if err := Pretouch(reflect.TypeOf(v),
option.WithCompileRecursiveDepth(1),
option.WithCompileMaxInlineDepth(2),
); err != nil {
t.Errorf("err:%v", err)
}
}