XeLabs/sonic
2
0
Fork 0
mirror of https://github.com/ii64/sonic.git synced 2026-06-20 16:45:22 +08:00
Code Issues Projects Releases Wiki Activity

fix: not initialize cap and len of emptyslice (#438)

Browse source
This commit is contained in:
liu 2023-05-29 11:16:36 +08:00 committed by GitHub
parent fe92cceb51
commit d7db21691c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 46 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/decoder/assembler_amd64_go116.go
View file

@ -1656,6 +1656,8 @@ func (self *_Assembler) _asm_OP_check_empty(p *_Instr) {
self.Sjmp("JNE" , "_not_empty_array_{n}") // JNE _not_empty_array_{n} self.Sjmp("JNE" , "_not_empty_array_{n}") // JNE _not_empty_array_{n}
self.Emit("MOVQ", _AX, _IC) // MOVQ AX, IC self.Emit("MOVQ", _AX, _IC) // MOVQ AX, IC
self.StorePtr(_Zero_Base, jit.Ptr(_VP, 0), _AX) // MOVQ $zerobase, (VP) self.StorePtr(_Zero_Base, jit.Ptr(_VP, 0), _AX) // MOVQ $zerobase, (VP)
self.Emit("PXOR" , _X0, _X0) // PXOR X0, X0
self.Emit("MOVOU", _X0, jit.Ptr(_VP, 8)) // MOVOU X0, 8(VP)
self.Xjmp("JMP" , p.vi()) // JMP {p.vi()} self.Xjmp("JMP" , p.vi()) // JMP {p.vi()}
self.Link("_not_empty_array_{n}") self.Link("_not_empty_array_{n}")
} else { } else {

2
internal/decoder/assembler_amd64_go117.go
View file

@ -1646,6 +1646,8 @@ func (self *_Assembler) _asm_OP_check_empty(p *_Instr) {
self.Sjmp("JNE" , "_not_empty_array_{n}") // JNE _not_empty_array_{n} self.Sjmp("JNE" , "_not_empty_array_{n}") // JNE _not_empty_array_{n}
self.Emit("MOVQ", _AX, _IC) // MOVQ AX, IC self.Emit("MOVQ", _AX, _IC) // MOVQ AX, IC
self.StorePtr(_Zero_Base, jit.Ptr(_VP, 0), _AX) // MOVQ $zerobase, (VP) self.StorePtr(_Zero_Base, jit.Ptr(_VP, 0), _AX) // MOVQ $zerobase, (VP)
self.Emit("PXOR", _X0, _X0) // PXOR X0, X0
self.Emit("MOVOU", _X0, jit.Ptr(_VP, 8)) // MOVOU X0, 8(VP)
self.Xjmp("JMP" , p.vi()) // JMP {p.vi()} self.Xjmp("JMP" , p.vi()) // JMP {p.vi()}
self.Link("_not_empty_array_{n}") self.Link("_not_empty_array_{n}")
} else { } else {

42
issue_test/issue437_test.go Normal file
View file

@ -0,0 +1,42 @@
/*
* Copyright 2023 ByteDance Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package issue_test
import (
`github.com/bytedance/sonic`
`encoding/json`
`testing`
`github.com/stretchr/testify/require`
)
// Person document for testing
type Person struct {
Name string `bson:"name,omitempty"`
Age uint `bson:"age,omitempty"`
}
func TestIssue437(t *testing.T) {
stdv := []Person{{Name: "hello world"}}
sonicv := []Person{{Name: "hello world"}}
data := []byte(`[]`)
stde := json.Unmarshal(data, &stdv)
sonice := sonic.ConfigStd.Unmarshal(data, &sonicv)
require.Equal(t, stde, sonice)
require.Equal(t, stdv, sonicv)
}